Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream Priority Support #1778

Merged
merged 6 commits into from
Jul 6, 2021
Merged

Stream Priority Support #1778

merged 6 commits into from
Jul 6, 2021

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Jun 28, 2021

Adds a new (optional) parameter to set a 16-bit priority on a stream that controls the relative order between the streams to send the data out.

Still need to figure out some testing.

@nibanks nibanks added Area: API Area: Core Related to the shared, core protocol logic labels Jun 28, 2021
@nibanks nibanks requested a review from a team as a code owner June 28, 2021 20:21
@anrossi
Copy link
Contributor

anrossi commented Jun 29, 2021

I think we should document that stream priorities take effect on the next queued send for that stream. So if a stream is queued for send at default priority, and then the application changes the priority, they understand it won't take effect until the next StreamSend call.

@nibanks nibanks merged commit 5677bb6 into main Jul 6, 2021
@nibanks nibanks deleted the nibanks/stream-priority branch July 6, 2021 22:01
@nibanks nibanks mentioned this pull request Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: API Area: Core Related to the shared, core protocol logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants